TinyMCE per block: Having a more controlled output markup #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I'm adding a serialize/parse methods to the block API to ease working with the block and generating the final markup.
parse: takes a raw block (the output of the grammar parser) and returns a simpler block object to be used by the form. The only requirement, it should have a
blockTypeattribute.serialize: takes the parsed black and should return the grammar block to be serialized to HTML
--
This PR adds a fallback mechanism where we fallback to the default
textblock if theparsemethod returns false, which means the content can not be parsed.