Apply box-sizing border-box properly to the notices components #17066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
requested review from
ajitbohra,
chrisvanpatten,
gziolo and
talldan
as code owners
Contributor
|
Yep. I can't test this right now, about to head to dinner, but based purely on looking at the code 👍 👍. I really do wish border-box was the default box sizing method. |
youknowriad
added
the
Good First Review
donmhico
pushed a commit
to donmhico/gutenberg
that referenced
this pull request
Aug 27, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
daniloercoli
added a commit
that referenced
this pull request
Sep 4, 2019
into rnmobile/add-autosave-to-mobile * 'rnmobile/master' of https://github.com/WordPress/gutenberg: (52 commits) [RNMobile] DarkMode improvements (#17309) Remove redundant bg color within button appender (#17325) Support group block on mobile (#17251) [RNMobile] Insure tapping at end of post inserts at end Recover border colors (#17269) [RNMobile] Fix dismiss keyboard button for the post title (#17260) Unify media placeholder and upload props within media-text (#17268) MediaUpload and MediaPlaceholder unify props (#17145) Add native support for the MediaText block (#16305) Activate Travis CI on rnmobile/master branch (#17229) [RNMobile] Native mobile release v1.11.0 (#17181) Apply box-sizing border-box properly to the notices components (#17066) Writing Flow: allow undo of patterns with BACKSPACE and ESC (#14776) Project automation: Rewrite actions using JavaScript (#17080) Build: remove global install of latest npm since we want to use the paired node/npm version (#17134) Writing Flow/Quote: allow splitting (#17121) Use `400` as a valid `font-weight` Add: Disabled block count in the block manager (#17103) Update video player style on mobile - Add a new gridicon play icon, from: https://github.com/Automattic/gridicons/blob/87c9fce08b4a9f184b9fb4963228757fdd4f4e74/svg-min/gridicons-play.svg - Replace the Dashicon play by this one - Update icon size and icon color - Update the overlay color [RNMobile] Hide replaceable block when adding block (#16931) ... # Conflicts: # packages/block-editor/src/components/block-list/index.native.js # packages/block-editor/src/components/inserter/index.native.js # packages/block-editor/src/components/inserter/menu.native.js # packages/block-editor/src/components/media-placeholder/index.native.js # packages/block-editor/src/components/warning/index.native.js # packages/block-library/src/code/edit.native.js # packages/block-library/src/image/edit.native.js # packages/block-library/src/missing/edit.native.js # packages/block-library/src/more/edit.native.js # packages/block-library/src/nextpage/edit.native.js # packages/block-library/src/video/edit.native.js # packages/components/src/mobile/bottom-sheet/cell.native.js # packages/components/src/mobile/bottom-sheet/index.native.js # packages/components/src/mobile/dark-mode/index.native.js # packages/components/src/mobile/html-text-input/index.native.js # packages/components/src/toolbar/toolbar-container.native.js # packages/edit-post/src/components/header/header-toolbar/index.native.js # packages/edit-post/src/components/layout/index.native.js # packages/edit-post/src/components/visual-editor/index.native.js # packages/rich-text/src/component/index.native.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17045
regressed in #16856
Instead of restoring the CSS reset, I opted to use a more "portable" fix making the styles of the notices components independent from any global reset by adding the "border-box" box-sizing where needed.