Skip to content

RichText: run input rule on composition end #17610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ellatrix merged 1 commit into from
Sep 26, 2019
Merged

RichText: run input rule on composition end #17610

ellatrix merged 1 commit into from
Sep 26, 2019

Conversation

@ellatrix
Copy link
Member

@ellatrix ellatrix commented Sep 26, 2019 •
edited
Loading

Description

Fixes input rules on composition end, after #14776.

How has this been tested?

On an American keyboard, press Alt+`, type "test", press Alt+`, and finally Space. The result should be <code>test</code>.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix ellatrix added the [Package] Rich text /packages/rich-text label Sep 26, 2019
@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Sep 26, 2019
youknowriad
youknowriad approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks

@ellatrix
Copy link
Member Author

ellatrix commented Sep 26, 2019

I created puppeteer/puppeteer#4981 to request composition events for Puppeteer. :)

@ellatrix ellatrix merged commit 559de9e into master Sep 26, 2019
@ellatrix ellatrix deleted the fix/input-rule-composition branch September 26, 2019 14:10
@youknowriad youknowriad added this to the Gutenberg 6.6 milestone Sep 30, 2019
youknowriad pushed a commit that referenced this pull request Sep 30, 2019
@ellatrix @youknowriad
RichText: run input rule on composition end (#17610)
842383b
youknowriad pushed a commit that referenced this pull request Sep 30, 2019
@ellatrix @youknowriad
RichText: run input rule on composition end (#17610)
976c3d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowriad youknowriad youknowriad approved these changes

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

@etoledom etoledom Awaiting requested review from etoledom

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

Assignees

No one assigned

Labels

[Package] Rich text /packages/rich-text [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 6.6

Development

Successfully merging this pull request may close these issues.

3 participants

@ellatrix @youknowriad