-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[RNMobile] Introduce grouping in the block settings inspector #17703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lukewalczak
merged 13 commits into
WordPress:master
from
callstack:rnmobile/grouping-block-settings
Oct 18, 2019
Merged
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
223a1b2
Intrdouce groupin in the block settings inspector
lukewalczak efe3565
Resolve conflicts along with merging master
lukewalczak e5c82f9
Adjust PanelBody to design
lukewalczak 0f7574e
Adjust padding when section doesnt have title
lukewalczak 03d5d8f
Rewirte arrow function to function
lukewalczak 4a7eb42
Fix lint issue
lukewalczak 63223ae
Create a PanelActions component for handling action buttons in the bl…
lukewalczak a7123e5
Remove useless separator type and fix typo
lukewalczak 0d07aa1
Merge branch 'master' into rnmobile/grouping-block-settings
lukewalczak 86a406e
Refactor after CR
lukewalczak 4340d87
Correct label styles
lukewalczak 50e0f8b
Fix overriding mechanism on label style
pinarol 2802d47
Merge remote-tracking branch 'upstream/master' into rnmobile/grouping…
lukewalczak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
packages/block-editor/src/components/block-settings/container.native.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| .content { | ||
| padding-left: 0; | ||
| padding-right: 0; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| .paddedPanelContainer { | ||
| padding: 0 16px; | ||
| } | ||
|
|
||
| .panelContainer { | ||
| padding: 0 0; | ||
| } | ||
|
|
||
| .noTitleContainer { | ||
| padding-top: 24; | ||
| } | ||
|
|
||
| .sectionHeaderText { | ||
| color: #87a6bc; | ||
| padding-top: 24; | ||
| padding-bottom: 8; | ||
| font-size: 14; | ||
| font-weight: 500; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.