Mobile gallery draft #18111
Closed
Mobile gallery draft #18111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkevins
added
[Status] In Progress
This was referenced Oct 25, 2019
5 tasks
This was referenced Oct 29, 2019
…ft-tiles', 'try/gallery-draft-buttons', 'try/gallery-draft-extract-gallery', 'try/gallery-draft-add-native-gallery' and 'try/gallery-draft-gallery-image' into try/gallery-draft-octo
mkevins
force-pushed
the
try/gallery-draft
branch
from
f24811a to
8fafcd0
Compare
…t-tiles' and 'try/gallery-draft-buttons' into try/gallery-draft
* WIP - add gallery button * Fix lint errors * Remove isString check from gallery button
mkevins
force-pushed
the
try/gallery-draft
branch
from
7d6c89d to
14422b6
Compare
mkevins
changed the base branch from
master
to
try/gallery-draft-extract-gallery
mkevins
changed the base branch from
try/gallery-draft-extract-gallery
to
master
Contributor
Author
|
Closing this draft as superseded by this PR: #18265. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description - 🚧 WORK IN PROGESS 🚧
This PR is a first iteration for a semi-cross-platform Gallery block. This is in a draft state (i.e. not ready for review). I have opened smaller PRs with smaller changesets to facilitate more focused discussion around the components used here.
The
gutenbergPRs for this feature have been rebased into a hierarchy described below. This "top level" PR can be used to test the aggregate changeset and integration of components within these related PRs.Sibling PRs from other repositories
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#1498
WordPress-Android: wordpress-mobile/WordPress-Android#10703
PR Hierarchy
GalleryImage: [RNMobile] Gallery - GalleryImage component #18155
Gallery Button: [RNMobile] Gallery - Button #18264
This has been merged intoGalleryImagePR for review there.✔️ Tiles: [RNMobile] Gallery - Tiles component #18130
🚧 Native Gallery: [RNMobile] Gallery - Native gallery component draft #18176
MediaPlaceholder: [RNMobile] Gallery - Add append logic to MediaPlaceholder #18262
This has been merged into the Native Gallery PR for review there.Extract Gallery: Extract Gallery component for semi-cross-platform Gallery block #18265