-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[RNMobile] Gallery - GalleryImage component #18155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
c470dfe
Add native gallery - gallery image
pinarol 2e3e93a
WIP - refactor native gallery image
mkevins 4865abd
WIP - gallery image - deselect caption when image tapped
mkevins 30f09e2
Add MediaUploadProgress to GalleryImage
mkevins 8d6f78d
Extract styles from gallery image
mkevins 1d409a3
Add failed upload UI to gallery image
mkevins 77ff571
Remove HOC from gallery image
mkevins 596e3ab
Remove unused props / methods in gallery image
mkevins 01f7b05
Remove gallery image when upload is cancelled
mkevins d62c85d
Remove unused code from gallery image
mkevins c77d8cd
Use accessibilityLabel prop on gallery image buttons
mkevins d5d6aba
Remove href code from gallery image
mkevins 685a361
Extract remaining styles from gallery image
mkevins 7b779e3
Fix lint errors
mkevins d12c5dc
[RNMobile] Gallery - Button (#18264)
mkevins d539cae
Fix isCropped style for mobile gallery image
mkevins 47d1c37
Use withPreferredColorScheme in gallery image
mkevins 7c77fa2
Add colorScheme styles for gallery image container
mkevins 1b04436
Fix lint
mkevins 52ddde2
Add buttonActive style for gallery image
mkevins 1f12a91
Clean up button styles on gallery image
mkevins 9109d7a
Fix lint
mkevins 9393545
Accept style override props in RichText
mkevins 5aabf79
Condense gallery changes to native RichText component
mkevins 28b676e
Use withPreferredColorScheme HOC for gallery caption
mkevins e212fd5
Add some caption styles to gallery image
mkevins 37bd880
Fix lint
mkevins 438a4e1
Refactor GalleryImage styles
mkevins 1758be3
Add ellipsis mode and ScrollView to gallery caption
mkevins 51a1c87
Extract gallery caption type flags for readability
mkevins 7880f45
Use RichText force blur prop in GalleryImage
mkevins 839383b
Fix lint
mkevins b42894e
Remove unnecessary View from gallery button
mkevins 1a625d2
Adjust gallery button icon styles
mkevins b8687a1
Center align gallery caption text
mkevins 8a85d4d
Adjust gallery caption font-size to 12px
mkevins 4ce0110
Use RichText to display unselected GalleryImage caption
mkevins 406417b
Use child-first approach for gallery image UI components
mkevins a05c203
Fix lint
mkevins 46295c3
Use full height for gallery caption scroll view
mkevins f47fc02
Use transparent background by default for gallery caption
mkevins adc3dfc
Eliminate <p> tags in gallery image caption
mkevins f96bfdb
Use variables instead of functions in gallery image scss
mkevins 2152170
Extract gallery button icon sizes to constants
mkevins 703c4ea
Tidy up gallery image style constants
mkevins 664b35a
Fix scss imports for jest
mkevins b982d1d
Use "p" tagName in gallery image on iOS to fix alignment
mkevins c7ab5cb
Trigger travis
mkevins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use full height for gallery caption scroll view
- Loading branch information
commit 46295c3c434c04c74383db25f587189f7adad70c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.