Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
5f3a400
Revert package-lock.json
lukewalczak Oct 17, 2019
25832f0
Merge branch 'master' into rnmobile/spacer
lukewalczak Oct 17, 2019
335154d
Setting attributes for spacer height
lukewalczak Oct 18, 2019
d137d38
Correct the condition for setting maximum value
lukewalczak Oct 21, 2019
8d37161
Merge branch 'master' into rnmobile/spacer
lukewalczak Oct 21, 2019
ae5715f
Small code refactor
lukewalczak Oct 23, 2019
a1cf07b
Improve Accessibility in range-cell
lukewalczak Oct 23, 2019
f0b3b28
Merge branch 'master' into rnmobile/spacer
lukewalczak Oct 23, 2019
a807c31
More accessibility improvements
lukewalczak Oct 23, 2019
ca3b8d4
Small code refactor
lukewalczak Oct 23, 2019
a390d88
Styling spacer refactor
lukewalczak Oct 24, 2019
90fe027
Move logic to RangeCell
lukewalczak Oct 24, 2019
a1d9a10
Keep Slider along with TextInput within RangeCell
lukewalczak Oct 24, 2019
833cc76
Small cleanup
lukewalczak Oct 24, 2019
103493e
Merge branch 'master' into rnmobile/spacer
lukewalczak Oct 24, 2019
74d020a
Fix missing binds
lukewalczak Oct 24, 2019
8c127b9
Fix focusing slider on iphoneX when VO is on
lukewalczak Oct 28, 2019
84ade89
Adjust a11y voice over
lukewalczak Oct 28, 2019
11e0911
Refactor RangeCell styles
lukewalczak Oct 28, 2019
1debc8c
Refactor pointerEvents when screen reader is on
lukewalczak Oct 28, 2019
4a897fd
Announce current value when finished
lukewalczak Oct 28, 2019
80a4714
Merge branch 'rnmobile/spacer' into rnmobile/rangecell-styling
lukewalczak Oct 28, 2019
047a08e
Small cleanup
lukewalczak Oct 29, 2019
7ee822e
Improve a11y
lukewalczak Oct 29, 2019
6d4dde4
Merge branch 'rnmobile/spacer' into rnmobile/rangecell-styling
lukewalczak Oct 29, 2019
014cd20
Fix a11y on iPhoneX
lukewalczak Oct 30, 2019
9f28b60
Merge branch 'rnmobile/spacer' into rnmobile/rangecell-styling
lukewalczak Oct 30, 2019
2e5c346
Refactor after CR
lukewalczak Oct 30, 2019
2d643c0
Update info for translators
lukewalczak Oct 30, 2019
f66a118
Merge branch 'rnmobile/spacer' into rnmobile/rangecell-styling
lukewalczak Oct 30, 2019
80104f1
Correct styles
lukewalczak Oct 30, 2019
93b7d58
Merge branch 'master' into rnmobile/rangecell-styling
lukewalczak Nov 5, 2019
26e7939
Refactor texts localizing
lukewalczak Nov 5, 2019
d321afd
merge master
jbinda Nov 6, 2019
b9c2b64
fix allowReset prop
jbinda Nov 7, 2019
cf85c25
Patch allowReset
lukewalczak Nov 7, 2019
500d414
a11y improvements
lukewalczak Nov 7, 2019
5d89738
Refactor custom button
lukewalczak Nov 8, 2019
7cd2f4f
Remove numberOfLines from cell label
lukewalczak Nov 8, 2019
ac07efa
Merge branch 'master' into rnmobile/rangecell-styling
lukewalczak Nov 15, 2019
135c4eb
Merge branch 'master' into rnmobile/rangecell-styling
lukewalczak Nov 15, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Announce current value when finished
  • Loading branch information
lukewalczak committed Oct 28, 2019
commit 4a897fd98823b879d010ab77d6f14e5115c44f22
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,9 @@ class BottomSheetRangeCell extends Component {
}

handleChange( text ) {
const announcement = sprintf( __( 'Current value is %s' ), text );
if ( ! isNaN( Number( text ) ) ) {
this.setState( { sliderValue: text } );
AccessibilityInfo.announceForAccessibility( announcement );
this.announceCurrentValue( text );
}
}

Expand Down Expand Up @@ -79,6 +78,7 @@ class BottomSheetRangeCell extends Component {
if ( ! isNaN( Number( text ) ) ) {
this.onChangeValue( text );
this.setState( { sliderValue: text } );
this.announceCurrentValue( text );
}
}

Expand All @@ -104,6 +104,11 @@ class BottomSheetRangeCell extends Component {
}
}

announceCurrentValue( value ) {
const announcement = sprintf( __( 'Current value is %s' ), value );
AccessibilityInfo.announceForAccessibility( announcement );
}

render() {
const {
value,
Expand Down