Skip to content

[RNMobile] Gallery - Native gallery component draft #18176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkevins merged 19 commits into from
Dec 4, 2019
Merged

[RNMobile] Gallery - Native gallery component draft #18176

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
7307cbd
Add native gallery
pinarol Oct 10, 2019
9064548
Add native gallery block behind DEV flag
pinarol Oct 10, 2019
b6e293d
Refactor gallery to accept props more directly
mkevins Oct 16, 2019
3b823da
Pass isBlockSelected prop to gallery-image
mkevins Oct 25, 2019
aaf6f47
Pass isCropped prop to gallery-image
mkevins Oct 25, 2019
3940800
Limit displayed columns on mobile for gallery
mkevins Oct 25, 2019
d479eef
Fix lint errors
mkevins Oct 29, 2019
347d338
Use renamed tiles spacing prop in native gallery component
mkevins Nov 5, 2019
c4eb41a
[RNMobile] Gallery - Add append logic to MediaPlaceholder (#18262)
mkevins Nov 7, 2019
138e4ac
Add margin-bottom to tiles in native gallery
mkevins Nov 12, 2019
36cd524
Limit displayed gallery columns to 4 for viewports < large
mkevins Nov 12, 2019
61167b4
Fix lint
mkevins Nov 12, 2019
00d6eba
Add darkmode styles for MediaPlaceholder appender
mkevins Nov 20, 2019
aa0dcb3
Use child-first approach for gallery image UI components
mkevins Nov 21, 2019
69b5f0d
Limit displayed columns in gallery to 4 on native
mkevins Nov 26, 2019
4c0bbc6
Add block-level caption to native gallery
mkevins Nov 28, 2019
07c46b2
Fix scss imports for jest
mkevins Nov 28, 2019
cfc6f45
Fix lint
mkevins Nov 28, 2019
3fcb972
Use "narrow" instead of "mobile" semantics for viewport flag
mkevins Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Limit displayed gallery columns to 4 for viewports < large
  • Loading branch information
@mkevins
mkevins committed Dec 4, 2019
commit 36cd524691bb449a46cab546aad47544155e47ac
4 changes: 3 additions & 1 deletion packages/block-library/src/gallery/gallery.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export const Gallery = ( props ) => {
isSelected,
// setAttributes,
isMobile,
isNarrow,
} = props;

const {
Expand All @@ -40,7 +41,8 @@ export const Gallery = ( props ) => {
images,
} = attributes;

const displayedColumns = isMobile ? Math.min( columns, 2 ) : columns;
const displayedColumns = isMobile ? Math.min( columns, 2 ) :
isNarrow ? Math.min( columns, 4 ) : columns;

return (
<View>
Expand Down