-
Notifications
You must be signed in to change notification settings - Fork 4.7k
WIP: Try/navigator in sidebar for nav and menu items #18203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think this works really nicely. It has the caveat that it only works so seamlessly when it's rendered in the same position for the parent and child blocks. If the descriptions of the two blocks were different lengths there'd be a noticeable jump of the position of the panel. In terms of implementation, at the moment I'm rendering the same component in both the Nav Menu and Menu Item I wonder if a better approach would be to create a slot that's like and rendering would be taken care of for all inner menu items. |
|
This looks very promising and might be an indication we should turn the top level block navigator into a sidebar so that it can remain open if you want to dig into structure. |
06f8f6a to
cae25f8
Compare
|
I refactored this along the lines mentioned in comment #18203 (comment). The Navigation Structure panel is now only rendered in the navigation menu in a When experimenting with larger navigation menus, the panel does get quite big, so I think I'll next try out a sidebar tab as @mtias mentions #18203 (comment). |
… Nav Menu and Menu Item blocks
cae25f8 to
254a5d5
Compare
…block navigator header button.
|
Noting #18340 has some points relating to this. Specifically, we now have 2 places. |
Description
Experiment to test the Block Navigator in the sidebars of both the Navigation Menu and Menu Item blocks.
This has been done in a very hacky way, it's just a proof of concept right now, not meant to be code reviewed.
This is an iteration from #18202
Screenshots