Skip to content

Fix hidden nested images in content column #18347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 5 commits into from
Nov 12, 2019
Merged

Fix hidden nested images in content column #18347

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0d6636
Update style.scss
CreativeDive Oct 7, 2019
4e84614
Fix visually hidden image for content column
CreativeDive Nov 6, 2019
63f553c
Fix hidden nested images in content column
CreativeDive Nov 6, 2019
894a2c5
Merge pull request #1 from CreativeDive/CreativeDive-patch-1
CreativeDive Nov 6, 2019
add8ff1
Update packages/block-editor/src/components/block-list/style.scss
CreativeDive Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/block-list/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@
// Left
&[data-align="left"] {
// This is in the editor only; the image should be floated on the frontend.
.block-editor-block-list__block-edit {
> .block-editor-block-list__block-edit {
/*!rtl:begin:ignore*/
float: left;
margin-right: 2em;
Expand Down
4 changes: 2 additions & 2 deletions packages/block-library/src/media-text/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@
vertical-align: middle;
}

.wp-block-media-text.is-image-fill figure {
.wp-block-media-text.is-image-fill figure.wp-block-media-text__media {
height: 100%;
min-height: 250px;
background-size: cover;
}

.wp-block-media-text.is-image-fill figure > img {
.wp-block-media-text.is-image-fill figure.wp-block-media-text__media > img {
// The image is visually hidden but accessible to assistive technologies.
position: absolute;
width: 1px;
Expand Down