Skip to content

added a Text component #18495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ItsJonQ merged 24 commits into from
Jan 7, 2020
Merged

added a Text component #18495

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
b804e72
added a Text component
Nov 13, 2019
de80cdc
avoid exporting and documenting the mixin
Nov 14, 2019
d3325eb
fix storybook title
Nov 14, 2019
56cc6cb
use kebab-case for file naming
Nov 14, 2019
f8e5d14
added a _default story with all variants in the one story
Nov 14, 2019
1dcff30
update styles
Nov 14, 2019
726aadd
update snapshots for react-native
Nov 14, 2019
5943ded
git and case-sensitive renames are the worst on macos
Nov 14, 2019
408a907
git and case-sensitive renames are the worst on macos
Nov 14, 2019
8d0d288
rename tests in kebab-case
Nov 14, 2019
8a87ff8
renamed snapshot files
Nov 17, 2019
1fe6f2f
d'oh forgot to fix the casing ina file
Nov 18, 2019
57e9542
update the readme to include when to use the component
Nov 24, 2019
10853c3
removed eslint disable rule
Nov 25, 2019
58e0ed2
update native snapshots
Nov 25, 2019
1d4ace8
delete unnecessary tests ready for visual regression testing
Nov 28, 2019
de00cb5
update storyshots
Nov 28, 2019
6d46659
commit updates to generated file
Dec 6, 2019
e659e10
renamed Text to __experimentalText
Dec 10, 2019
eee98ce
remove unnecessary files
Dec 13, 2019
3fdd23f
fix formatting
Dec 13, 2019
0967a4d
Update formatting of typings
jameslnewell Dec 13, 2019
b0d4d55
Mark stories as experimental
jameslnewell Dec 13, 2019
614a8ab
updated story snapshots
Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed eslint disable rule
  • Loading branch information
James Newell committed Jan 7, 2020
commit 10853c37ecfd2901682e91a80963d4282892449c
13 changes: 6 additions & 7 deletions packages/components/src/text/mixins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,21 +82,20 @@ const label = `
*/

/**
* @param {TextVariant} variant
* @param {TextVariant} variantName
*/
// eslint-disable-next-line no-shadow
const variant = ( variant ) => {
switch ( variant ) {
const variant = ( variantName ) => {
switch ( variantName ) {
case 'title.large':
return css`
${ title }
${ titleLarge }
`;
case 'title.medium':
return css`
${ title }
${ titleMedium }
`;
${ title }
${ titleMedium }
`;
case 'title.small':
return css`
${ title }
Expand Down