[Monorepo] Fix android build #18569
Merged
[Monorepo] Fix android build #18569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dratwas
added
[Status] In Progress
Tug
changed the base branch from
rnmobile/import-mobile-fix-build-ios
to
feat/import-gutenberg-mobile-no-squash
Tug
force-pushed
the
rnmobile/import-mobile-fix-android-build
branch
from
57d886d to
a9caf86
Compare
|
Size Change: 0 B Total Size: 856 kB ℹ️ View Unchanged
|
…of @wordpress/react-native-editor in package-lock.json
Tug
force-pushed
the
rnmobile/import-mobile-fix-android-build
branch
from
5d2818b to
26c86b1
Compare
ceyhun
reviewed
Mar 26, 2020
ceyhun
approved these changes
Mar 26, 2020
Member
ceyhun
left a comment
ceyhun
left a comment
There was a problem hiding this comment.
I was able to run the demo app successfully both from command line and Android Studio 🎉
Contributor
|
Merging this one with "merge commit" capability turned on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a part of migration gutenberg-mobile to gutenberg repo.
In this PR we fix the android build of the
react-native-editorexample app. In order to do that, we had to reorganize the dependencies (make react-native-bridge and react-native-aztec dependencies of react-native-editor), change paths to linked libraries in the android project, and use some tricks to be able to run the app from the root folder.How has this been tested?
npm run native bundle:androidshould create a JS bundlenpm run native start:resetandnpm run androidshould start android demo app (npm run android alone won't properly boot the metro server because of a limitation in react-native which ignores the --root argument in run-android)packages/react-native-editor/androidTypes of changes
fix android build of
react-native-editorexample appChecklist: