Skip to content

Conversation

@dratwas
Copy link
Contributor

@dratwas dratwas commented Nov 18, 2019

Description

This is a part of migration gutenberg-mobile to gutenberg repo.

In this PR I moved jitpack.yml file to the root level.

According to documentation https://jitpack.io/docs/BUILDING/ -> Custom commands

You can create a jitpack.yml file in the root of your repository and override the build commands:

I also changed yarn to npm in the jitpack script that builds the JS bundle.

How has this been tested?

  • change submodule URL in Wordpress-Android to gutenberg repo
  • checkout to the latest commit on the branch from this PR
  • set wp.BUILD_GUTENBERG_FROM_SOURCE = false in gradle.properites file
  • The app should build without issues

Types of changes

move jitpack.yml to the root level and fix jitpack build scripts

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@dratwas dratwas added [Type] Technical Prototype Offers a technical exploration into an idea as an example of what's possible [Status] In Progress Tracking issues with work in progress labels Nov 18, 2019
@dratwas dratwas mentioned this pull request Nov 20, 2019
21 tasks
@dratwas dratwas removed the [Status] In Progress Tracking issues with work in progress label Nov 20, 2019
@dratwas dratwas marked this pull request as ready for review November 20, 2019 10:08
@dratwas dratwas closed this Sep 28, 2020
@dratwas dratwas deleted the rnmobile/import-mobile-jitpack branch September 28, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Technical Prototype Offers a technical exploration into an idea as an example of what's possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants