Skip to content

Align Dropdown and DropdownMenu styles #18631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 5 commits into from
Nov 21, 2019
Merged

Align Dropdown and DropdownMenu styles #18631

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f2a562
Add a story to compare both menus
youknowriad Nov 20, 2019
5806cf9
Align the toggle styles
youknowriad Nov 20, 2019
b2dbb88
Restore the DropdownMenu indicator
youknowriad Nov 20, 2019
210dd5c
Fix unit tests
youknowriad Nov 21, 2019
ac172ac
Remove specific toolbar button styles
youknowriad Nov 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix unit tests
  • Loading branch information
@youknowriad
youknowriad committed Nov 21, 2019
commit 210dd5c06c971da6c6dc396e23de54a46e184281
4 changes: 2 additions & 2 deletions packages/components/src/color-palette/test/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ exports[`ColorPalette Dropdown should render it correctly 1`] = `
renderToggle={[Function]}
>
<div
className="components-circular-option-picker__dropdown-link-action"
className="components-dropdown components-circular-option-picker__dropdown-link-action"
>
<ForwardRef(Button)
aria-expanded={false}
Expand Down Expand Up @@ -436,7 +436,7 @@ exports[`ColorPalette should render a dynamic toolbar of colors 1`] = `
renderToggle={[Function]}
>
<div
className="components-circular-option-picker__dropdown-link-action"
className="components-dropdown components-circular-option-picker__dropdown-link-action"
>
<ForwardRef(Button)
aria-expanded={false}
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-post/src/components/header/more-menu/test/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ exports[`MoreMenu should match snapshot 1`] = `
renderToggle={[Function]}
>
<div
className="components-dropdown-menu edit-post-more-menu"
className="components-dropdown components-dropdown-menu edit-post-more-menu"
>
<ForwardRef(IconButton)
aria-expanded={false}
Expand Down