Skip to content

[RNMobile] Long-press on inserter to show options for "add above" and "add below" #18791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SergioEstevao merged 36 commits into from
Jan 29, 2020
Merged

[RNMobile] Long-press on inserter to show options for "add above" and "add below" #18791

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
9fdbf76
Add onLongPress prop to Button
ceyhun Nov 16, 2019
d1e7ea2
Show inserter menu on long press
ceyhun Nov 16, 2019
4ecb48d
Make onLongPress a prop of toggle
ceyhun Nov 23, 2019
d6b716e
Make withSelect of Inserter return destinationRootClientId
ceyhun Nov 23, 2019
46d8206
Insert default block before the selected one on long press
ceyhun Nov 23, 2019
0d13ef7
Add add canReplaceBlock key to the insertionPoint state
ceyhun Nov 26, 2019
3fee2af
Hide a block in list only if it can be replaced
ceyhun Nov 26, 2019
07cd4fa
Move insertion index logic from menu to inserter
ceyhun Nov 26, 2019
df0c42b
Update selector tests for newly added key in state
ceyhun Nov 30, 2019
cd74cfc
Update docs for newly added key in state
ceyhun Nov 30, 2019
9fcfe3b
Add insertionIndexAfter and isAnyBlockSelected props with selector
ceyhun Nov 30, 2019
eb2ec38
Refactor insertion index logic
ceyhun Dec 1, 2019
8771782
Add insertionType to component state and map to insertion index
ceyhun Nov 30, 2019
c7101b8
Show BottomSheet on long press to choose to insert before or after
ceyhun Nov 30, 2019
4bc8825
Update UI strings to be title case
ceyhun Dec 3, 2019
2430eb3
Hide cancel button from Bottom Sheet on Android
ceyhun Dec 6, 2019
1ccf577
Add icons to Bottom Sheet options on Android
ceyhun Dec 8, 2019
ececc84
Add “Replace Current Block” option to menu on long-press
ceyhun Dec 8, 2019
aa7231b
Scroll to newly added block if it doesn't trigger keyboard to open
ceyhun Dec 8, 2019
a42307a
Change “Replace Current Block” menu icon on Android
ceyhun Dec 16, 2019
20eab25
Use shorter syntax for setState
ceyhun Dec 16, 2019
2914a4b
Rename getShouldReplaceBlock method to shouldReplaceBlock
ceyhun Dec 16, 2019
5c14c4b
Revert "Scroll to newly added block if it doesn't trigger keyboard to…
ceyhun Dec 17, 2019
997a73d
Revert “Add canReplaceBlock key to the insertionPoint state"
ceyhun Dec 17, 2019
70062a0
Remove Block show/hide logic from BlockList
ceyhun Dec 17, 2019
c5a6079
Update Inserter local state to store block insertion information
ceyhun Dec 17, 2019
2ae9e99
Make InserterMenu add/remove unmodified default block during replace
ceyhun Dec 17, 2019
15f7651
Handle replacing last remaining block
ceyhun Dec 17, 2019
682c471
Fix Inserter test
ceyhun Dec 18, 2019
3b05a40
Fix code style issue
ceyhun Dec 18, 2019
8b35936
Move insertion options into getInsertionOptions function
ceyhun Dec 18, 2019
7f08b8d
Add comment about removing last block case
ceyhun Dec 18, 2019
b2c2fc8
Use findByProps instead of toJSON when testing Inserter
ceyhun Dec 18, 2019
5f1aec9
Merge branch 'master' into rnmobile/1433-long-press-on-inserter-to-sh…
ceyhun Jan 28, 2020
5164247
Merge branch 'master' into rnmobile/1433-long-press-on-inserter-to-sh…
ceyhun Jan 29, 2020
e345e42
Merge branch 'master' into rnmobile/1433-long-press-on-inserter-to-sh…
ceyhun Jan 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make withSelect of Inserter return destinationRootClientId
  • Loading branch information
@ceyhun
ceyhun committed Jan 8, 2020
commit d6b716ee9f67fd0fb6b91ac762318e8fba951cc5
5 changes: 1 addition & 4 deletions packages/block-editor/src/components/inserter/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { Dropdown, ToolbarButton, Dashicon } from '@wordpress/components';
import { Component } from '@wordpress/element';
import { withSelect } from '@wordpress/data';
import { compose, withPreferredColorScheme } from '@wordpress/compose';
import { getUnregisteredTypeHandlerName } from '@wordpress/blocks';

/**
* Internal dependencies
Expand Down Expand Up @@ -112,7 +111,6 @@ class Inserter extends Component {
export default compose( [
withSelect( ( select, { clientId, isAppender, rootClientId } ) => {
const {
getInserterItems,
getBlockRootClientId,
getBlockSelectionEnd,
} = select( 'core/block-editor' );
Expand All @@ -124,10 +122,9 @@ export default compose( [
destinationRootClientId = getBlockRootClientId( end ) || undefined;
}
}
const inserterItems = getInserterItems( destinationRootClientId );

return {
items: inserterItems.filter( ( { name } ) => name !== getUnregisteredTypeHandlerName() ),
destinationRootClientId,
};
} ),
withPreferredColorScheme,
Expand Down