Skip to content

Conversation

@maxme
Copy link
Contributor

@maxme maxme commented Nov 28, 2019

Description

Related PR in gutenberg-mobile: wordpress-mobile/gutenberg-mobile#1627

Details:

How has this been tested?

This should be tested in this gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1627 and in the apps directly.

Types of changes

No new changes, everything was introduced in separate PRs already.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@maxme maxme added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 28, 2019
Copy link
Member

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via related gb-mobile, WPAndroid, and WPiOS PR's. Spacer and image block issues all look good!

@maxme maxme merged commit db956c4 into master Nov 29, 2019
@maxme maxme deleted the rnmobile/release-v1.18.0 branch November 29, 2019 15:18
@mkevins mkevins restored the rnmobile/release-v1.18.0 branch December 3, 2019 01:32
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
@mkevins mkevins deleted the rnmobile/release-v1.18.0 branch July 6, 2020 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants