Skip to content

Build: Output package type declarations #18942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirreal merged 65 commits into from
Mar 27, 2020
Merged

Build: Output package type declarations #18942

Changes from 1 commit
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
d1ec2b8
Add tsconfigs for packages
sirreal Feb 26, 2020
38814d0
Update TypeScript package
sirreal Feb 26, 2020
9c238dd
Add types
sirreal Feb 26, 2020
d6c5808
Gitignore types output
sirreal Feb 26, 2020
152ce84
Clean build-types
sirreal Feb 26, 2020
cd066a3
Add missing Parameters utility type
sirreal Feb 27, 2020
48cf167
Fix PriorityQueue types
sirreal Feb 27, 2020
d970cb3
Add sprintf-js types
sirreal Feb 27, 2020
62d2023
Type plural_forms function
sirreal Feb 27, 2020
8645170
Allow i18n implicit any for untyped dependencies
sirreal Feb 27, 2020
77c3835
Add include
sirreal Feb 27, 2020
fb52cee
Add tsbuildinfo locations
sirreal Feb 27, 2020
124a8b3
Clean the right directories
sirreal Feb 27, 2020
fcbff69
Remove root tsconfig
sirreal Feb 27, 2020
eb26707
Add build-types
sirreal Feb 27, 2020
bee32b5
Disable token-list types
sirreal Feb 27, 2020
af14a3e
Remove ts cache from cleanup
sirreal Feb 27, 2020
a10f1a5
Include build-types in files
sirreal Feb 27, 2020
d9141ec
Use "build" over "b"
sirreal Feb 27, 2020
9754612
Remove lint-types from lint
sirreal Feb 28, 2020
d6a20ea
Clean caches, some config cleanup
sirreal Mar 3, 2020
4cfe893
Remove redundant resolve
sirreal Mar 3, 2020
ba8e7c5
No async, no catch
sirreal Mar 5, 2020
214e1ff
Use default .tsbuildinfo location
sirreal Mar 5, 2020
1042f71
Clean up tsconfig
sirreal Mar 5, 2020
0cca987
"Fix" token-list
sirreal Mar 5, 2020
71b0dd8
Use eslint dis/enable no-console pair
sirreal Mar 5, 2020
1268c2f
Move types built to build:packages
sirreal Mar 5, 2020
80c0a02
Add TypeScript to packages/README
sirreal Mar 6, 2020
adbb0dd
Ignore cli input
sirreal Mar 6, 2020
973f5fb
Add build:package-types to lint-staged
sirreal Mar 6, 2020
09c9955
Add travis job
sirreal Mar 6, 2020
2e3bdce
Add and use lint-staged-typecheck bin
sirreal Mar 6, 2020
7c277f4
Update bin/packages/lint-staged-typecheck.js
sirreal Mar 6, 2020
d11fe6a
Restructure is-shallow-equal
sirreal Mar 7, 2020
384c78e
Bump to TS 3.8.3
sirreal Mar 11, 2020
36d4649
Type TokenList
sirreal Mar 11, 2020
7e71ee6
Add project-management-automation to typed packages
sirreal Mar 20, 2020
5ab371b
Use lib for uncompiled published code
sirreal Mar 20, 2020
8fc3c0e
Fix implicit any type
sirreal Mar 20, 2020
7dc9a43
Disable noImplicitAny for pma
sirreal Mar 20, 2020
94b9451
Exclude react-native
sirreal Mar 20, 2020
3230e83
Restore native checking, relax implicit any
sirreal Mar 20, 2020
47b24c3
Improve is-shallow-equal structure
sirreal Mar 21, 2020
448fd2f
Proposal: Use root ts project
sirreal Mar 22, 2020
ad9f5bc
Use double quotes in package scripts
sirreal Mar 25, 2020
7e9a6e1
Only clean types on publish
sirreal Mar 25, 2020
e2d8f86
Run lint-stage via npm script
sirreal Mar 25, 2020
9151cd1
Remove is-shallow-equal/{arrays,objects} support
sirreal Mar 25, 2020
70b1c2e
Proposal: Check all types on lint-staged
sirreal Mar 25, 2020
ad17ba1
Drop tsc verbose build
sirreal Mar 25, 2020
1251ec6
Fix types in token-list
sirreal Mar 25, 2020
8dffe92
Explain lint-staged script with a comment
sirreal Mar 26, 2020
0236148
Restore bin typechecking
sirreal Mar 26, 2020
89a0540
Comment cache outdir
sirreal Mar 26, 2020
9c5782c
Remove redundant entry from is-shallow-equal files
sirreal Mar 26, 2020
c4516f3
Disable declarationMap for bin
sirreal Mar 26, 2020
adb7a78
Add types to package.json lint
sirreal Mar 27, 2020
a213ca9
Update is-shallow-equal benchmarks
sirreal Mar 27, 2020
6ee66b5
Update is-shallow-equal tests
sirreal Mar 27, 2020
4d95dc0
Revert "Explain lint-staged script with a comment"
sirreal Mar 27, 2020
bc0eac3
Revert "Proposal: Check all types on lint-staged"
sirreal Mar 27, 2020
3fbe6f2
Revert "Run lint-stage via npm script"
sirreal Mar 27, 2020
a9c8577
Log type errors with lint-staged
sirreal Mar 27, 2020
dfd2bc1
Update changelog for affected packages
sirreal Mar 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Drop tsc verbose build
  • Loading branch information
@sirreal
sirreal committed Mar 26, 2020
commit ad17ba1322280a857b8c8d418c9f858f7aaf7795
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@
"clean:package-types": "tsc --build --clean",
Copy link
Member

@gziolo gziolo Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t it be part of clean:packages that is executed as prebuild:packages?

Copy link
Member Author

@sirreal sirreal Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some conversation around this in the thread here: #18942 (comment)

In summary, there's enormous benefit to having a warm TypeScript cache and I don't believe there's any reason to clean it except to remove outdated declaration files from packages before they will be published.

In particular, we'll want to keep the caches warm for typechecking as part of lint staged.

"prebuild:packages": "npm run clean:packages && lerna run build",
"build:packages": "npm run build:package-types && node ./bin/packages/build.js",
"build:package-types": "tsc --build --verbose",
"build:package-types": "tsc --build",
"build": "npm run build:packages && wp-scripts build",
"check-engines": "wp-scripts check-engines",
"check-licenses": "concurrently \"wp-scripts check-licenses --prod --gpl2\" \"wp-scripts check-licenses --dev\"",
Expand Down