Skip to content

Editor: Shim meta attribute source on registered edit component #18960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 10 commits into from
Dec 6, 2019
Merged

Editor: Shim meta attribute source on registered edit component #18960

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9e5f8e6
E2E Tests: Enqueue meta attribute test block at correct action
aduth Dec 5, 2019
75a7ff9
Editor: Shim meta attribute source on registered `edit` component
aduth Dec 5, 2019
417cc8a
Editor: Remove unused name explicit destructuring
aduth Dec 6, 2019
140000d
Editor: Improve wording around attribute merging, updating
aduth Dec 6, 2019
5a1294b
Editor: Clarify attribute meta mapping description
aduth Dec 6, 2019
8bbe636
Editor: Improve meta override behavior description
aduth Dec 6, 2019
842d061
Editor: Pass dependencies array to useSelect
aduth Dec 6, 2019
94f5416
Editor: Rename metaKeys to metaAttributes
aduth Dec 6, 2019
b4aecdd
Editor: Update filter function docs to possessive "block's"
aduth Dec 6, 2019
35e2c8c
Editor: Remove newline between imported typedefs
aduth Dec 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Editor: Improve wording around attribute merging, updating 
Co-Authored-By: Enrique Piqueras <epiqueras@users.noreply.github.com>
  • Loading branch information
@aduth @epiqueras
aduth and epiqueras authored Dec 6, 2019
commit 140000dbaeec563113a6e4b30c3e7d99942adc0f
2 changes: 1 addition & 1 deletion packages/editor/src/hooks/custom-sources-backwards-compatibility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { addFilter } from '@wordpress/hooks';

/**
* Given a meta attribute mapping, returns a new higher-order component which
* manages attributes merging and updates to consume from and mirror to the
* manages attribute merging and updating to consume from and mirror to the
* associated entity record.
*
* @param {WPMetaAttributeMapping} metaKeys Meta attribute mapping.
Expand Down