Skip to content

Add a Latest Comments block #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danielbachhuber wants to merge 15 commits into from
Closed

Add a Latest Comments block #1931

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
681b479
First pass at a basic Latest Comments block
danielbachhuber Jul 17, 2017
dcbebc4
Add fixtures for latest comments block
danielbachhuber Jul 25, 2017
33b2571
Add controls for toggling avatar, excerpt and timestamp
danielbachhuber Jul 25, 2017
b6c3340
Render timestamp when `displayTimestamp=true`
danielbachhuber Jul 25, 2017
74cc5f3
Use the actual post title in the comment summary
danielbachhuber Jul 25, 2017
526b864
Render avatar when `displayAvatar=true`
danielbachhuber Jul 25, 2017
ccf0694
Render excerpt when `displayExcerpt=true`
danielbachhuber Jul 25, 2017
f792e24
Put controls in display order
danielbachhuber Jul 25, 2017
16b8160
Fall back to 'Untitled' when no title is present
danielbachhuber Jul 25, 2017
f829b5a
Use currying function for de-duplicating toggling handlers
westonruter Jul 29, 2017
798b04e
Eliminate latency when decrementing comment count
westonruter Aug 1, 2017
4e416fb
Fix avatar floating and improve reliability of obtaining avatar size
westonruter Aug 1, 2017
829b3f8
Add initial server-side rendering of Latest Comments block
westonruter Aug 1, 2017
611dec0
Add author name to comment list
westonruter Aug 2, 2017
e0e9088
Fix tests for latest-comments attributes
westonruter Aug 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fall back to 'Untitled' when no title is present
  • Loading branch information
@danielbachhuber @westonruter
danielbachhuber authored and westonruter committed Aug 3, 2017
commit 16b8160a144696454a749a7589e39eada188af6e
2 changes: 1 addition & 1 deletion blocks/library/latest-comments/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ registerBlockType( 'core/latest-comments', {
{ displayAvatar && comment.author_avatar_urls[ 96 ] &&
<img className={ `${ this.props.className }__comment-avatar` } alt={ comment.author_name } src={ comment.author_avatar_urls[ 96 ] } />
}
<a href={ comment.link } target="_blank">{ comment._embedded.up[ 0 ].title.rendered }</a>
<a href={ comment.link } target="_blank">{ comment._embedded.up[ 0 ].title.rendered.trim() || __( '(Untitled)' ) }</a>
{ displayTimestamp && comment.date_gmt &&
<span className={ `${ this.props.className }__comment-timestamp` }>
{ moment( comment.date_gmt ).local().format( 'MMM DD h:mm A' ) }
Copy link
Member Author

@danielbachhuber danielbachhuber Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This timestamp format seems like it should be user-configurable. Maybe we need a JS implementation of human_time_diff() with a filterable format.

Copy link
Member

@westonruter westonruter Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moment.js does support relative time: https://momentjs.com/docs/#/displaying/fromnow/

It could be a nice block attribute to decide whether the dates are shown in relative time or absolute time, according to the site's datetime format.

See also #1992 (comment) and #1992 (comment)

Copy link
Member Author

@danielbachhuber danielbachhuber Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to the site's datetime format.

Should we get a new issue going about respecting the site's datetime format?

Copy link
Member

@westonruter westonruter Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielbachhuber done: #2013

Copy link
Member

@mtias mtias Aug 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it affects latest posts as well.

Expand Down