Skip to content

Keycodes: Add, enhance types #19520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirreal merged 11 commits into from
Dec 30, 2020
Merged

Keycodes: Add, enhance types #19520

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d05328b
Keycodes: Add, enhance types
aduth Jan 9, 2020
9a3a09f
Remove type widening
sirreal Nov 27, 2020
cee77a4
Fix getEventModifiers type
sirreal Nov 27, 2020
1244838
Some type cleanup
sirreal Nov 27, 2020
d3a4964
Add changelog entry
sirreal Nov 27, 2020
0fd4d2c
Cleanup types whitespace
sarayourfriend Dec 14, 2020
2e61206
Fix package.json property order
sarayourfriend Dec 15, 2020
cbac733
Use string constants for modifier parts
sirreal Dec 29, 2020
198bb1a
Remove unnecessary type parameter
sirreal Dec 29, 2020
23486f9
Use mapped type for modifiers
sirreal Dec 29, 2020
4100f14
Add js language hint to examples
sirreal Dec 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove type widening
  • Loading branch information
@sirreal
sirreal committed Dec 29, 2020
commit 9a3a09f2ac5147cc7aacfe4f10e71ac3904736c0
8 changes: 0 additions & 8 deletions packages/keycodes/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,29 +106,21 @@ export const F10 = 121;

/**
* Keycode for ALT key.
*
* @type {WPModifierPart}
*/
export const ALT = 'alt';

/**
* Keycode for CTRL key.
*
* @type {WPModifierPart}
*/
export const CTRL = 'ctrl';

/**
* Keycode for COMMAND/META key.
*
* @type {WPModifierPart}
*/
export const COMMAND = 'meta';

/**
* Keycode for SHIFT key.
*
* @type {WPModifierPart}
*/
export const SHIFT = 'shift';

Expand Down