Skip to content

Conversation

@ellatrix
Copy link
Member

@ellatrix ellatrix commented Jan 15, 2020

Description

Still a work in progress.

This PR makes it so that RichText sets the correct position selection when a block is split by RichText so the selection is directly set in the store instead of the block trying to query the first tabbable element inside the block (which may not be the element that has the split text). The technique is similar to the MERGE_BLOCKS effect.

I'll see if I can fix the selection on paste as well.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@Mamaduka
Copy link
Member

Closing this as stale.

  • Most of the core referenced here has been refactored or removed. An intensive rebasing is required to apply the patch.
  • The RichText splitting logic has improved since (Writing Flow/Rich Text: unify split logic #54543); the bug is probably resolved.

@Mamaduka Mamaduka closed this Apr 25, 2025
@Mamaduka Mamaduka deleted the try/rich-text-split-selection branch April 25, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] In Progress Tracking issues with work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants