Skip to content

Conversation

@aduth
Copy link
Member

@aduth aduth commented Jan 17, 2020

This pull request seeks to address a few consistency issues with the LinkControl documentation:

  • There is no className prop
  • value is not required
  • onChange will always receive an item, never null
  • The onChange example referenced the wrong (old) prop onLinkChange, and the example used an impossible scenario that the changed item could be falsey.
  • The tests reference behavior of "required props", but there are no required props

Separately, I would like to improve documentation and types concerning what a value actually is. These are intended as an incremental step in that direction.

Testing Instructions:

The only changes impact documentation and tests. There is no expected impact on the behavior of the application runtime.

Ensure unit tests pass:

npm run test-unit

@aduth aduth added [Type] Developer Documentation Documentation for developers [Type] Code Quality Issues or PRs that relate to code quality [Package] Block editor /packages/block-editor labels Jan 17, 2020
@aduth aduth requested review from getdave and youknowriad January 17, 2020 21:12
@aduth aduth mentioned this pull request Jan 17, 2020
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Block editor /packages/block-editor [Type] Code Quality Issues or PRs that relate to code quality [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants