Skip to content

Block Editor: LinkControl: Resolve error when undefined value, "view" state #19856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 3 commits into from
Jan 28, 2020
Merged

Block Editor: LinkControl: Resolve error when undefined value, "view" state #19856

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19b918e
Block Editor: LinkControl: Resolve error when undefined value, "view"…
aduth Jan 24, 2020
bc5e696
Block Editor: LinkControl: Document only url, title, opensInNewTab va…
aduth Jan 28, 2020
1e55842
Block Editor: LinkControl: Change documented example to reference kno…
aduth Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Block Editor: LinkControl: Document only url, title, opensInNewTab va… 
…lue properties
  • Loading branch information
@aduth
aduth committed Jan 28, 2020
commit bc5e69688fd6c9f66c7236666a0e4536c5be63d5
8 changes: 3 additions & 5 deletions packages/block-editor/src/components/link-control/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,9 @@ A link value contains is composed as a union of the default properties and any c

Default properties include:

- id (`string|number`): Unique identifier of link.
- url (`string`): Link URL.
- title (`string`): Link title.
- type (`string`): Type of link entity.
- subtype (`string`): Subtype of link entity.
- `url` (`string`): Link URL.
- `title` (`string`, optional): Link title.
- `opensInNewTab` (`boolean`, optional): Whether link should open in a new browser tab.This value is only assigned if not providing a custom `settings` prop.

### settings

Expand Down
14 changes: 5 additions & 9 deletions packages/block-editor/src/components/link-control/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,11 @@ import LinkControlSearchInput from './search-input';
*
* @typedef WPLinkControlDefaultValue
*
* @property {string|number} id Unique identifier of link.
* @property {string} url Link URL.
* @property {string} title Link title.
* @property {string} type Type of link entity.
* @property {string} subtype Subtype of link entity.
* @property {boolean} [opensInNewTab] Whether link should open in a new
* browser tab. This value is only
* assigned if not providing a custom
* settings array.
* @property {string} url Link URL.
* @property {string=} title Link title.
* @property {boolean=} opensInNewTab Whether link should open in a new browser
* tab. This value is only assigned if not
* providing a custom `settings` prop.
*/

/**
Expand Down