Block Library: Social Link: Consistently rename sites to services #20150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Block] Social
jorgefilipecosta
approved these changes
Feb 10, 2020
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
I tested this PR with the three styles of social links all of them worked well 👍
Contributor
|
Thanks for picking this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #19887
This pull request seeks to update all functions and references within functions of the Social Link block to reference "services" instead of "sites". Pending confirmation, it appears this was an intended change from #19887, but not all references to the "sites" terminology was included.
Testing Instructions:
There should be no regressions in the insertion, operation, or preview of a Social Links block.
Confirm in code there are no lingering reference to "site".