-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix: Styling problem on vertically aligned blocks #20368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Styling problem on vertically aligned blocks #20368
Conversation
|
Size Change: +27 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
|
In my quick test, this does appear to work as intended with no side-effects. Nice work! 👍 👍 |
|
I'm a bit confused what impact I might also be a little concerned how well an explicit |




Description
Fixes: #19962
Props to @mrleemon for suggesting this fix.
Some blocks did not work inside the columns block, this PR adds a CSS fix for the issue.
In my tests, the fix does not seem to have unexpected consequences.
cc: @aduth, @jasmussen, @getdave I would appreciate if you could double-check if this fix works as expected.
How has this been tested?
I added a columns block with two columns.
I added the Image Slider Block from the "Ultimate Blocks" plugin inside with some images inside the first column.
I added sample text on the second column making the height of the second column higher than the one of the first column.
I vertically aligned the columns to the three possible values and verified for each alignment the result looked correct. (On master the slider is broken).