Media & Text Block: Fix frontend styles when "Crop image to fill" is selected #20539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fill" option active
jffng
requested review from
Soean,
ajitbohra,
jorgefilipecosta and
talldan
as code owners
WunderBart
requested changes
Mar 2, 2020
Member
WunderBart
left a comment
WunderBart
left a comment
There was a problem hiding this comment.
Nice catch, @jffng! Thanks for your quick reaction.
Tested it locally and noticed that it breaks the Editor part back:
Renaming the figure element class in edit.js to wp-block-media-text__media should do the trick. I guess we could then remove those styles as they seem redundant 🙌
WunderBart
added
[Block] Media & Text
WunderBart
approved these changes
Mar 3, 2020
Member
WunderBart
left a comment
WunderBart
left a comment
There was a problem hiding this comment.
Tested locally, both editor and view display the image properly when "Crop image to fill the column" option is set.
Nice work, thanks! 🚢
WunderBart
changed the title
jorgefilipecosta
added
the
Backport to WP 6.9 Beta/RC
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 9, 2020
…selected (#20539) * Fix selectors for frontend styles of media text block w/ "Crop image to fill" option active * Rename editor container class and remove redundant block styles
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 10, 2020
…selected (#20539) * Fix selectors for frontend styles of media text block w/ "Crop image to fill" option active * Rename editor container class and remove redundant block styles
jorgefilipecosta
removed
the
Backport to WP 6.9 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#20439 introduced a bug that broke the "Crop image to fill entire column" styles on the front end.
This PR reverts the names of those selectors for the front-end styles, while leaving the fixes for the editor styles in place.