Skip to content

Use a light wrapper for the image block #20576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 7 commits into from
Mar 5, 2020
Merged

Use a light wrapper for the image block #20576

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d4d69e4
Use a light wrapper for the image block
youknowriad Mar 2, 2020
a292f40
Fix placeholder alignment
youknowriad Mar 2, 2020
38d8054
Use Array.includes
youknowriad Mar 4, 2020
422c225
Rewrite unit test as e2e test
ellatrix Mar 4, 2020
e7b0466
Fix lint problem
ellatrix Mar 4, 2020
9051acd
Restore toolbar margin for full width
ellatrix Mar 4, 2020
473a952
Ensure floated images are clickable
ellatrix Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use Array.includes 
Co-Authored-By: Zebulan Stanphill <zebulanstanphill@protonmail.com>
  • Loading branch information
@youknowriad @ZebulanStanphill @ellatrix
2 people authored and ellatrix committed Mar 4, 2020
commit 38d8054702646742fe3839a9a9169ab5c682e2fc
2 changes: 1 addition & 1 deletion packages/block-library/src/image/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ export class ImageEdit extends Component {
/>
);
const needsAlignmentWrapper =
[ 'center', 'left', 'right' ].indexOf( align ) !== -1;
[ 'center', 'left', 'right' ].includes( align );

const mediaPlaceholder = (
<MediaPlaceholder
Expand Down