Skip to content

[ Latest Posts ] Fix link for read more markup #20917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorgefilipecosta merged 1 commit into from
Mar 18, 2020
Merged

[ Latest Posts ] Fix link for read more markup #20917

jorgefilipecosta merged 1 commit into from
Mar 18, 2020

Conversation

@draganescu
Copy link
Contributor

@draganescu draganescu commented Mar 16, 2020

Description

Fixes #20783

How has this been tested?

  1. Make sure you have some posts
  2. Add a page or post
  3. Add a LatestPosts block
  4. Set the block to show post content > excerpt
  5. Check that the URL of the read more link is correct

Screenshots

Screenshot 2020-03-16 at 10 48 45

@draganescu draganescu added [Type] Bug An existing feature does not function as intended [Block] Latest Posts Affects the Latest Posts Block Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Mar 16, 2020
@github-actions
Copy link

github-actions bot commented Mar 16, 2020 •
edited
Loading

Size Change: +4 B (0%)

Total Size: 857 kB

Filename Size Change
build/block-library/index.js 111 kB +4 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.01 kB 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.03 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 100 kB 0 B
build/block-editor/style-rtl.css 10.7 kB 0 B
build/block-editor/style.css 10.7 kB 0 B
build/block-library/editor-rtl.css 7.23 kB 0 B
build/block-library/editor.css 7.24 kB 0 B
build/block-library/style-rtl.css 7.42 kB 0 B
build/block-library/style.css 7.43 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.7 kB 0 B
build/components/index.js 191 kB 0 B
build/components/style-rtl.css 15.7 kB 0 B
build/components/style.css 15.7 kB 0 B
build/compose/index.js 6.22 kB 0 B
build/core-data/index.js 10.6 kB 0 B
build/data-controls/index.js 1.04 kB 0 B
build/data/index.js 8.21 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 91.3 kB 0 B
build/edit-post/style-rtl.css 8.62 kB 0 B
build/edit-post/style.css 8.62 kB 0 B
build/edit-site/index.js 4.64 kB 0 B
build/edit-site/style-rtl.css 2.53 kB 0 B
build/edit-site/style.css 2.53 kB 0 B
build/edit-widgets/index.js 4.45 kB 0 B
build/edit-widgets/style-rtl.css 2.58 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 381 B 0 B
build/editor/editor-styles.css 382 B 0 B
build/editor/index.js 43.8 kB 0 B
build/editor/style-rtl.css 3.97 kB 0 B
build/editor/style.css 3.96 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.09 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.92 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.49 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.68 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.85 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.49 kB 0 B
build/priority-queue/index.js 779 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.3 kB 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@draganescu draganescu changed the title fixes docblock [ Latest Posts ] Fix link for read more markup Mar 16, 2020
@draganescu draganescu force-pushed the fix/latest-posts-read-more-html branch from 9498031 to 0ed8a7d Compare March 16, 2020 11:28
adamziel
adamziel approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@adamziel adamziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly!

youknowriad
youknowriad reviewed Mar 16, 2020
View reviewed changes
packages/block-library/src/latest-posts/edit.js
'target="_blank" rel="noopener noreferrer">' +
'" target="_blank" rel="noopener noreferrer">' +
__( 'Read more' ) +
'</a>'
Copy link
Contributor

@youknowriad youknowriad Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we're concatening HTML and using RawHTML. security-wise, it seems better to just use JSX.

Copy link
Contributor Author

@draganescu draganescu Mar 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think there is a reason :)

Copy link
Contributor

@mcsf mcsf Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@draganescu, can you prioritise a fix?

Copy link
Contributor Author

@draganescu draganescu Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Howdy @youknowriad and @mcsf a fix is ready in #21170

@jorgefilipecosta jorgefilipecosta merged commit b72b41e into master Mar 18, 2020
@jorgefilipecosta jorgefilipecosta deleted the fix/latest-posts-read-more-html branch March 18, 2020 18:01
@github-actions github-actions bot added this to the Gutenberg 7.8 milestone Mar 18, 2020
@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Mar 18, 2020

Merging this PR as it was approved and seems to fix the problem.
I think as a follow up we should refactor to avoid RawHTML and rely on jsx.

@jorgefilipecosta jorgefilipecosta added the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 18, 2020
@jorgefilipecosta jorgefilipecosta mentioned this pull request Mar 23, 2020
Merged
jorgefilipecosta pushed a commit that referenced this pull request Mar 23, 2020
@draganescu @jorgefilipecosta
[ Latest Posts ] Fix link for read more markup (#20917)
fdc2c36
jorgefilipecosta pushed a commit that referenced this pull request Mar 23, 2020
@draganescu @jorgefilipecosta
[ Latest Posts ] Fix link for read more markup (#20917)
81839dc
@draganescu draganescu mentioned this pull request Mar 26, 2020
Merged
@jorgefilipecosta jorgefilipecosta removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcsf mcsf mcsf left review comments

@youknowriad youknowriad youknowriad left review comments

@adamziel adamziel adamziel approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees

No one assigned

Labels

[Block] Latest Posts Affects the Latest Posts Block Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 7.8

Development

Successfully merging this pull request may close these issues.

[ Latest Posts ] Markup issue for Read more link inside the editor

6 participants

@draganescu @jorgefilipecosta @mcsf @adamziel @youknowriad