Remove slimImageObjects method since happening in MediaUploadButton #2110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2110 +/- ##
=========================================
- Coverage 23.11% 23.1% -0.01%
=========================================
Files 141 141
Lines 4405 4402 -3
Branches 747 747
=========================================
- Hits 1018 1017 -1
+ Misses 2856 2854 -2
Partials 531 531
Continue to review full report at Codecov.
|
mkaz
force-pushed
the
fix/gallery-slimimages
branch
from
9ea70d0 to
50907cd
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little bit of cleanup - the slimImageObjects method removes unneeded attributes from the image objects. This method was previous done within gallery but was refactored and moved into the MediaUploadButton so no longer needed here. This change removes the method.
See #1820