Interface: move Fullscreen mode component to interface package #21334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vindl
changed the title
|
Size Change: +728 B (0%) Total Size: 885 kB
ℹ️ View Unchanged
|
Contributor
Addison-Stavlo
left a comment
Addison-Stavlo
left a comment
There was a problem hiding this comment.
Smoke tested the editors. This works well on my end!
6 tasks
noahtallen
approved these changes
Apr 2, 2020
Member
noahtallen
left a comment
noahtallen
left a comment
There was a problem hiding this comment.
This works perfectly for me as well. My only thought (similar to the other PR) is that we should probably update style.scss. For example, edit-post-fullscreen-mode__slide-in-animation could probably be renamed. edit-post-header also seems out of place (especially since we use this from edit-site), but that might need updated somewhere else
Contributor
|
I personally think the header animation is not useful at all epsecially since it's fullscreen by default, I'd vote for removing it which would save us the need to move it to the right package (edit-post since the element is rendered there) cc @kjellr |
Member
Author
I agree, especially in light of this exploration which will make it obsolete #21121. |
Move Fullscreen mode component from block-editor to interface package.
vindl
force-pushed
the
update/fullscreen-to-interface
branch
from
e2bd307 to
72246c8
Compare
Member
Author
|
I removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move Fullscreen mode component from block-editor to interface package.
How has this been tested?
Toggle the fullscreen mode in post editor and site editor and verify that they still work as expected.
Types of changes
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist: