Fix: Make sidebars pinned by default. #21645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
Size Change: -192 B (0%) Total Size: 840 kB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
fix/make-sidebars-pinned-by-default
branch
from
5d0c10b to
ab7ac75
Compare
jorgefilipecosta
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
youknowriad
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: #21635
This PR fixes a regression introduced in #20698 that made sidebars unpinned by default while previously they were pinned by default.
I'm expanding our end to end sidebar test suite to cover this regression. A follow up should be proposed soon.
How has this been tested?
I installed the Yoast plugin.
I made the local storage empty using
window.localStorage.clear();.I opened the editor and verified the Yoast sidebar was one of the pinned items.
I verified the sidebars worked as expected and it was still possible to unpin items.