Skip to content

Remove negative margin on help text #21846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnstonphilip wants to merge 4 commits into from
Closed

Remove negative margin on help text #21846

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec9b126
Remove negative margin on help text
johnstonphilip Apr 23, 2020
be58a86
Remove inherit margin-bottom, re-add negative margin
johnstonphilip Apr 23, 2020
8f0909b
Go back to removing negative margin instead since it is most recent c…
johnstonphilip Apr 23, 2020
2968df0
Go back to removing inherited margin if in a panel row
johnstonphilip Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Go back to removing negative margin instead since it is most recent c… 
…hange
  • Loading branch information
@johnstonphilip
johnstonphilip committed Apr 23, 2020
commit 8f0909b0ce7b2e32231cf079e701b83e2e85ae2f
5 changes: 4 additions & 1 deletion packages/components/src/base-control/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

.components-base-control__field {
margin-bottom: $grid-unit-10;

.components-panel__row & {
margin-bottom: inherit;
}
}

.components-base-control__label {
Expand All @@ -12,7 +16,6 @@
}

.components-base-control__help {
margin-top: -$grid-unit-10;
font-style: italic;
}
}