Skip to content

RangeControl: Fix number input change interaction #22084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ItsJonQ merged 11 commits into from
May 11, 2020
Merged

RangeControl: Fix number input change interaction #22084

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1e38b31
RangeControl: Fix number input change interaction
May 4, 2020
1069650
Update packages/components/src/utils/hooks.js
May 5, 2020
b58e9cb
Update packages/components/src/utils/hooks.js
May 5, 2020
1383dba
Update packages/components/src/range-control/input-field.js
May 5, 2020
60e3f80
Update packages/components/src/range-control/utils.js
May 5, 2020
400e621
Rename handleOnSubmit to handleOnCommit
May 5, 2020
ff4b356
Add tests and comments for useControlledState
May 5, 2020
f30ac77
Renamed stateRef to lastInitialStateRef for clarity
May 5, 2020
55bc26e
Merge branch 'master' into fix/rangecontrol-min-max-input
May 11, 2020
9647605
Fix reset callback to use resetFallbackValue, if defined. Add tests.
May 11, 2020
7d09603
Add doc for resetFallbackValue
May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/components/src/utils/hooks.js 
Co-authored-by: Andrew Duthie <andrew@andrewduthie.com>
  • Loading branch information
@aduth
Jon Quach and aduth authored May 5, 2020
commit b58e9cb5229156c4c758f0f2c34f3810a5f09f00
2 changes: 1 addition & 1 deletion packages/components/src/utils/hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { useEffect, useRef, useState } from '@wordpress/element';
* https://reactjs.org/docs/forms.html#controlled-components
*
* @param {any} initialState The initial state value.
* @return {Array<any, Function>} The controlled value and the value setter.
* @return {[*, Function]} The controlled value and the value setter.
*/
export function useControlledState( initialState ) {
const [ state, setState ] = useState( initialState );
Expand Down