Scripts: Add official flags for build and start scripts #22310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 834 kB ℹ️ View Unchanged
|
gziolo
added
[Tool] WP Scripts
gziolo
requested review from
ajitbohra,
nerrad,
ntwb and
youknowriad
as code owners
youknowriad
reviewed
May 13, 2020
|
|
||
| - New `--webpack-no-externals` flag added to `build` and `start` scripts. It disables scripts' assets generation, and omits the list of default externals ([#22310](https://github.com/WordPress/gutenberg/pull/22310)). | ||
| - New `--webpack-bundle-analyzer` flag added to `build` and `start` scripts. It enables visualization for the size of webpack output files with an interactive zoomable treemap ([#22310](https://github.com/WordPress/gutenberg/pull/22310)). | ||
| - New `--webpack--devtool` flag added to `start` script. It controls how source maps are generated. See options at https://webpack.js.org/configuration/devtool/#devtool ([#22310](https://github.com/WordPress/gutenberg/pull/22310)). |
Contributor
There was a problem hiding this comment.
Do we need wepack in the name or is it just an implementation detail?
Member
Author
There was a problem hiding this comment.
We need a way to filtering those flags. We did something similar for puppeteer. We could whitelist them to not pass to webpack (jest fails when you pass it unknown flag), too. I’m fine with renaming
sgomes
reviewed
May 14, 2020
Contributor
sgomes
left a comment
sgomes
left a comment
There was a problem hiding this comment.
The changes regarding the bundle analyzer seem good, but I left a question/comment below.
Member
Author
|
Let's move forward with it. It was a long-standing issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #21827.
Closes #14492.
This PR adds 3 new flags to use with
buildandstartscripts from@wordpress/scripts:--webpack-no-externalsflag added tobuildandstartscripts. It disables scripts' assets generation, and omits the list of default externals.--webpack-bundle-analyzerflag added tobuildandstartscripts. It enables visualization for the size of webpack output files with an interactive zoomable treemap.--webpack--devtoolflag added tostartscript. It controls how source maps are generated. See options at https://webpack.js.org/configuration/devtool/#devtool.WP_LIVE_RELOAD_PORTwasn't exposed as a flag because its future is uncertain. It might get replaces with React Fast Refresh as proposed in #21008.How has this been tested?
One way to test it by running
npm run analyze-bundlesin Gutenberg that was updated to use--webpack-bundle-analyzerflag.Types of changes
New features (non-breaking change which adds functionality).
Checklist: