[ Navigation Screen ] adds notifications base system #22326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds a sample notification for saving menus - fixes a empty menu items crashing the menu page
|
Size Change: +190 B (0%) Total Size: 832 kB
ℹ️ View Unchanged
|
talldan
approved these changes
May 15, 2020
Comment on lines
+136
to
+138
| createSuccessNotice( __( 'Navigation saved.' ), { | ||
| type: 'snackbar', | ||
| } ); |
Contributor
There was a problem hiding this comment.
In my testing this displays immediately instead of waiting for a successful save as this is a synchronous function. As mentioned in #21344, it's really hard to tell when a save has completed.
Lets merge anyway, but keep the issue open. I know there are other PRs like #22148 that would change this completely, so probably good to see some progress around that first.
Contributor
Author
There was a problem hiding this comment.
Yes, I think so as well, wrote in the description "Advances #21344" :) so we don't close it. We need more PRs for the other notifications as well (like location editing).
Thanks for reviewing and merging! 🙇
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advances #21344
Description
Adds the base needed to enable notifications on the navigation screen.
How has this been tested?
I added a sample notification for saving menus.
Screenshots
Types of changes
Non breaking changes.
Also fixes a bug in master with empty menus, apparently brought by #21671