Skip to content

Block API: Extend register_block_type_from_metadata to handle assets #22519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gziolo merged 14 commits into from
Jun 12, 2020
Merged

Block API: Extend register_block_type_from_metadata to handle assets #22519

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1c9fba7
Blocks: Extend `register_block_type_from_metadata` to hanle assets
gziolo May 21, 2020
33749a9
Update lib/compat.php
gziolo May 22, 2020
0cd683f
Map explicitly from metadata to settings to filter out unwanted fields
gziolo May 22, 2020
39d9b61
Improve error handling by following register from the WP_Block_Type_R…
gziolo May 22, 2020
4681cfe
Update unit tests for register_block_from_metadata
gziolo May 22, 2020
3ac1cb8
Add handling for scripts/style handles and paths
gziolo May 27, 2020
f38e744
Remove styleVariations alias in favor of the supported styles property
gziolo May 27, 2020
7ae6a80
Improve readability of the metada file path handling
gziolo May 27, 2020
2bd1c35
Introduce helper functions for working with asset files
gziolo Jun 3, 2020
1817354
Docs: Reflect proposed changes for block.json handling of asset files'
gziolo Jun 3, 2020
850d9fd
Correct the way asset paths are handled
gziolo Jun 4, 2020
8fdeea0
Add missing example field in block metadata processing
gziolo Jun 4, 2020
7a16c96
Add basic unit tests to cover functions that register handles
gziolo Jun 4, 2020
551a4bc
Add more tests covering automatic block asset registration
gziolo Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove styleVariations alias in favor of the supported styles property
  • Loading branch information
@gziolo
gziolo committed Jun 4, 2020
commit f38e74484b4d739054132adb9eaa87ef999089f8
2 changes: 0 additions & 2 deletions lib/compat.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ function register_block_type_from_metadata( $file_or_folder, $args = array() ) {
'attributes' => 'attributes',
'supports' => 'supports',
'styles' => 'styles',
// Alias recommended in documentation to distinguish from assets.
'styleVariations' => 'styles',
);

foreach ( $property_mappings as $key => $mapped_key ) {
Expand Down
2 changes: 1 addition & 1 deletion phpunit/class-wp-rest-block-types-controller-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ public function test_get_item_invalid() {
'keywords' => 'invalid_keywords',
'parent' => 'invalid_parent',
'supports' => 'invalid_supports',
'styleVariations' => 'invalid_styles',
'styles' => 'invalid_styles',
'render_callback' => 'invalid_callback',
);
register_block_type( $block_type, $settings );
Expand Down
2 changes: 1 addition & 1 deletion phpunit/fixtures/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"align": true,
"lightBlockWrapper": true
},
"styleVariations": [
"styles": [
{
"name": "default",
"label": "Default",
Expand Down