Blocks: Capture and recover from block rendering runtime errors #2267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to add error handling to block edit rendering. Error boundaries are a new feature added in React 16 which add a simple
componentDidCatchlifecycle hook to capture errors which occur during a component's rendering. With these changes, an error boundary wraps rendering of each block and captures errors, presenting a warning message if one occurs, rather than allowing it to go unhandled and crash the entire application.Implementation notes:
The original implementation attempt applied
componentDidCatchtoVisualEditorBlockitself but this had some odd effects oncomponentDidMountand refs, so it was later revised to create a separate wrapping error boundary component.Testing instructions:
wp.blocks.registerBlockType( 'myplugin/mr-crashy', { title: 'Mr. Crashy', category: 'common', icon: 'warning', edit() { throw new Error(); }, save() { return ''; } } );Open questions: