Skip to content

GalleryBlock: remove unused CSS and cleanup front-end. #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtias merged 3 commits into from
Aug 10, 2017
Merged

GalleryBlock: remove unused CSS and cleanup front-end. #2291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff0fc6a
GalleryBlock: remove unused CSS and cleanup front-end.
mtias Aug 8, 2017
88deabd
Remove images check.
mtias Aug 8, 2017
c5bbfad
Prevent aligncenter classes (often defined with themes) from removing…
mtias Aug 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions blocks/library/gallery/block.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
.wp-block-gallery {
.wp-block-gallery,
.wp-block-gallery.aligncenter {
display: flex;
flex-wrap: wrap;

&:not( .components-placeholder ) {
margin-right: -16px;
margin-bottom: -16px;
}

.blocks-gallery-image {
flex-grow: 1;
margin: 0 16px 16px 0;
Expand Down
23 changes: 3 additions & 20 deletions blocks/library/gallery/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,6 @@
.wp-block-gallery.is-placeholder {
margin: -15px;
padding: 6em 0;
border: 2px solid $light-gray-500;
text-align: center;
}

.blocks-gallery__placeholder-label {
display: flex;
align-items: center;
justify-content: center;
font-weight: bold;

.dashicon {
margin-right: 1ch;
}
}

.blocks-gallery__placeholder-instructions {
margin: 1.8em 0;
.wp-block-gallery:not( .components-placeholder ) {
margin-right: -16px;
Copy link
Member

@aduth aduth Aug 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorta feel the excess margin on gallery images could be better handled by an :nth-of-type( 2n ) { margin-right: 0; } etc.

margin-bottom: -16px;
}

.editor-visual-editor__block[data-type="core/gallery"] .editor-visual-editor__block-edit {
Expand Down