Skip to content

[Navigation screen] Replace component state and refs with Redux state #23033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamziel merged 30 commits into from
Jun 22, 2020
Merged

[Navigation screen] Replace component state and refs with Redux state #23033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
b176ee6
Squash
adamziel Jun 17, 2020
c05a9f9
menu editor -> navigation editor
adamziel Jun 17, 2020
38f2ffc
Rename CSS classes and shortcuts components to reflect menu vs naviga…
adamziel Jun 17, 2020
9000b88
"Privatize" concurrency-related actions
adamziel Jun 17, 2020
5141678
Migrate to uuid module
adamziel Jun 17, 2020
23b24e6
Remove persist: [ 'preferences' ]
adamziel Jun 17, 2020
ebf9586
Remove processing-related selectors in favor of controls which are no…
adamziel Jun 17, 2020
c475769
Wrap pending action in serializeProcessing()
adamziel Jun 17, 2020
c8a1d83
Rename processing to processingQueue
adamziel Jun 17, 2020
7343c84
Move the mapping back to state
adamziel Jun 17, 2020
ed929a8
Remove general resolveSelect control
adamziel Jun 17, 2020
79e8b41
Add undo/redo shortcuts
adamziel Jun 17, 2020
42e2ffd
Remove persist option in proper store
adamziel Jun 17, 2020
47709c4
Use the canonical way of keeping track of post resolution (and fix th…
adamziel Jun 18, 2020
93f5575
Add comments
adamziel Jun 18, 2020
03a9147
Enforce menuId to be string
adamziel Jun 18, 2020
5c3c387
Add unit tests for mapping reducer
adamziel Jun 18, 2020
b994b1a
Add unit tests for processingQueue reducer
adamziel Jun 18, 2020
204d354
Update comment on getNavigationPost selector
adamziel Jun 19, 2020
66139ba
Update comment on getNavigationPost
adamziel Jun 19, 2020
4464c7e
Ensure POP_PENDING_ACTION action don't mutate the state
adamziel Jun 19, 2020
bfb5e03
Rename getNavigationPost to getNavigationPostForMenu
adamziel Jun 19, 2020
b99b8aa
Handle empty nonce in batchSave
adamziel Jun 19, 2020
7cdc116
Don't export storeConfig
adamziel Jun 19, 2020
6b49ee0
Simplify useCallback
adamziel Jun 19, 2020
1021624
Rename NavigationEditorWrapper to NavigationEditor
adamziel Jun 19, 2020
170df1f
Ensure menuId is a number
adamziel Jun 19, 2020
c82b617
Add comments for all exported members of store/**/*.js
adamziel Jun 19, 2020
27eac24
Add comments to exported members of utils.js
adamziel Jun 19, 2020
7bf7e7c
Update package-lock.json
adamziel Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion packages/edit-navigation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"@wordpress/blocks": "file:../blocks",
"@wordpress/components": "file:../components",
"@wordpress/compose": "file:../compose",
"@wordpress/core-data": "file:../core-data",
"@wordpress/data": "file:../data",
"@wordpress/data-controls": "file:../data-controls",
"@wordpress/dom-ready": "file:../dom-ready",
Expand All @@ -48,7 +49,8 @@
"@wordpress/url": "file:../url",
"classnames": "^2.2.5",
"lodash": "^4.17.15",
"rememo": "^3.0.0"
"rememo": "^3.0.0",
"uuid": "^7.0.2"
},
"publishConfig": {
"access": "public"
Expand Down
71 changes: 0 additions & 71 deletions packages/edit-navigation/src/components/menu-editor/index.js
View file
Open in desktop

This file was deleted.

51 changes: 0 additions & 51 deletions packages/edit-navigation/src/components/menu-editor/promise-queue.js
View file
Open in desktop

This file was deleted.

43 changes: 0 additions & 43 deletions packages/edit-navigation/src/components/menu-editor/shortcuts.js
View file
Open in desktop

This file was deleted.

67 changes: 0 additions & 67 deletions packages/edit-navigation/src/components/menu-editor/use-create-missing-menu-items.js
View file
Open in desktop

This file was deleted.

Loading