[Mobile] - Copy, Cut, Paste, Duplicate blocks #23110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 9, 2020 18:44
… Move items rendering to its own component
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
2 tasks
geriux
added
the
Mobile App - i.e. Android or iOS
16 tasks
Contributor
|
I tested following cases both on WPAndroid and WPiOS, working awesome!
Tested the notice view with the steps here: #23113 |
pinarol
approved these changes
Jun 12, 2020
Contributor
pinarol
left a comment
pinarol
left a comment
There was a problem hiding this comment.
Working well and looking good 👍 Great job 👍
Let's prepare installable builds so @iamthomasbishop can test as well!
* Add notices * Remove duplicate function * Fix errors * Update NoticeList * Fix default val * Bind on notice hidden * Add timer and fix formatting * Prevent NoticeList from appearing inside nested blocks * Update animation * RNMobile - Notice - Fix animation * Add onDimensionsChange listener * RNMobile - FloatingToolbar - Disable pointer Events if its not visible * Make zIndex values get effective * Update packages/components/src/notice/index.native.js Co-authored-by: Gerardo Pacheco <[email protected]> * Update packages/components/src/notice/list.native.js Co-authored-by: Gerardo Pacheco <[email protected]> * Simplify reducer Co-authored-by: Gerardo Pacheco <[email protected]>
This was referenced Jun 12, 2020
added 5 commits
June 15, 2020 14:37
…component animation
# Conflicts: # packages/components/src/index.native.js
# Conflicts: # packages/editor/src/store/actions.native.js
geriux
changed the title
added 3 commits
June 25, 2020 18:50
# Conflicts: # packages/react-native-editor/ios/Podfile.lock
3 tasks
6 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#2378Notice view integration PR-> #23113WordPress iOS PR-> wordpress-mobile/WordPress-iOS#14392WordPress Android PR-> wordpress-mobile/WordPress-Android#12187Description
This PR adds the functionality to copy, cut, paste, and duplicate blocks. This would be very useful to be able to move blocks from inner blocks or to group blocks like Group or Columns.
It also includes a Notice view to show some small, self-dismissing messages at the top of the page. Plus, it integrates it with Copy, Cut events and
react-native-blurto be used on iOS only.Colors: Same colors with Tooltip.
Timeout: 3secs before self dismissing
Height: 30px
How has this been tested?
Steps to test
Copy / Paste block
After copying/cutting a block:
WPiOS:
WPAndroid:
Cut block
Duplicate block
Screenshots
👇👇👇
Click here to watch the video.
👆👆👆
UX Interaction
Light Mode
Dark Mode
Types of changes
New feature
Checklist: