Refactor column block to use hooks #23143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Block] Columns
Co-authored-by: Zebulan Stanphill <[email protected]>
ZebulanStanphill
approved these changes
Jun 15, 2020
Member
ZebulanStanphill
left a comment
ZebulanStanphill
left a comment
There was a problem hiding this comment.
The code looks good to go!
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Tested adding a a columns block, setting a vertical alignment then changing the vertical alignment of an inner column and checking that the parent Columns block alignment was reset.
Screenshots
Types of changes
Code quality
Checklist: