Adapt the block switcher styles to the new Popover component #23232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Automated Testing
|
Size Change: -2 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Jun 17, 2020
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
In my testing this solves the scrolling issue with the Switcher Menu. Hopefully it'll improve test stability too 👍
youknowriad
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #23159 The Popover component has been updated to auto-adjust on height changes. This cause a small regression on the Block Switcher popover since it was overriding the popover content styles.
This PR should fix it.
Testing instructions