Skip to content

Movers: Add bigger mobile touch targets. #23761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 3 commits into from
Aug 10, 2020
Merged

Movers: Add bigger mobile touch targets. #23761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d24892d
Movers: Add bigger mobile touch targets.
Jul 7, 2020
cd3b47e
Address focus size issue.
jasmussen Aug 3, 2020
c5d644d
Fix rebase issue.
jasmussen Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 37 additions & 26 deletions packages/block-editor/src/components/block-mover/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,14 @@
.block-editor-block-mover {
.components-toolbar-group,
.components-toolbar {
flex-direction: column;
flex: 1;

// Increase touch targets on mobile.
flex-direction: row;

@include break-small() {
flex-direction: column;
}
}

&.is-horizontal .components-toolbar-group,
Expand All @@ -25,42 +31,48 @@
}

.block-editor-block-mover-button {
height: $block-toolbar-height/2;
width: $block-toolbar-height;
padding: 0 !important;
@include break-small() {
padding: 0 !important;
height: $block-toolbar-height/2;
width: $block-toolbar-height;
}

// Focus style.
// Overrides .components-toolbar-group styles
&::before {
left: 0 !important;
right: 0 !important;
@include break-small() {
left: $grid-unit-10 !important;
right: $grid-unit-10 !important;
}
}
}

// Position the icons correctly.
.components-toolbar-group .block-editor-block-mover-button.is-up-button,
.components-toolbar .block-editor-block-mover-button.is-up-button {
svg {
margin-bottom: -$grid-unit-10;
}
@include break-small() {
.components-toolbar-group .block-editor-block-mover-button.is-up-button,
.components-toolbar .block-editor-block-mover-button.is-up-button {
svg {
margin-bottom: -$grid-unit-10;
}

// Focus style.
&::before {
bottom: 0;
height: calc(100% - #{ $border-width });
// Focus style.
&::before {
bottom: 0;
height: calc(100% - #{ $border-width });
}
}
}

.components-toolbar-group .block-editor-block-mover-button.is-down-button,
.components-toolbar .block-editor-block-mover-button.is-down-button {
svg {
margin-top: -$grid-unit-10;
}
.components-toolbar-group .block-editor-block-mover-button.is-down-button,
.components-toolbar .block-editor-block-mover-button.is-down-button {
svg {
margin-top: -$grid-unit-10;
}

// Focus style.
&::before {
top: 0;
height: calc(100% - #{ $border-width });
// Focus style.
&::before {
top: 0;
height: calc(100% - #{ $border-width });
}
}
}

Expand All @@ -70,7 +82,6 @@
height: $block-toolbar-height;
// Overrides .components-toolbar-group styles
width: $block-toolbar-height / 2;
min-width: $grid-unit-30;
padding-left: 0;
padding-right: 0;

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/toolbar-group/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ div.components-toolbar {
}

// Last button in a group.
.components-accessible-toolbar .components-toolbar-group > .components-button:last-child.has-icon,
.components-accessible-toolbar .components-toolbar-group > .components-button:last-of-type.has-icon,
.components-accessible-toolbar .components-toolbar-group > div:last-child > .components-button.has-icon,
.components-toolbar div:last-child .components-button.has-icon {
min-width: $block-toolbar-height - $grid-unit-15 / 2;
Expand Down