(JS) Color Values: Rename brand to theme. Add fallback values. #24059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Jul 20, 2020
| className, | ||
| currentInput, | ||
| color: colorProp = color( 'ui.brand' ), | ||
| color: colorProp = color( 'ui.theme' ), |
Contributor
There was a problem hiding this comment.
Is there any reason why not all use cases have fallbacks like this one?
Author
There was a problem hiding this comment.
This value is (eventually) passed into the styled generated component, which has a fallback:
https://github.com/WordPress/gutenberg/pull/24059/files#diff-bc2454ef211a3ab799a3f1c4dfe936c1R36
This workflow isn't ideal 🤦♀️ . I'm looking into an automated solution now.
I have something in mind 🤞
Contributor
There was a problem hiding this comment.
Agreed that automating would be good or at least a lint rule. But I'm willing to include this fix quickly if you think it's ready as is?
|
Size Change: +74 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
youknowriad
added
Backport to WP 6.9 Beta/RC
youknowriad
approved these changes
Jul 20, 2020
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Let's get the fix in and explore automation.
6 tasks
Author
|
Automatic CSS |
ellatrix
pushed a commit
that referenced
this pull request
Jul 20, 2020
5 tasks
youknowriad
removed
the
Backport to WP 6.9 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #23936
It fixes an IE11 regression for CSS variable support. It also renames the color
ui.brandusage toui.theme, which is feels more appropriate for this project.How has this been tested?
npm run devTypes of changes
At the moment, we have to manually add fallbacks for any CSS
var()usage (for CSS-in-JS generated styles). The Sass workflow offers automatic fallback generation thanks to it's PostCSS process. I recognize this isn't a great solution (especially at scale).We'll need to look into a more automated solution for CSS variable fallbacks (as well as other features like RTL handling).
Checklist: