Skip to content

InnerBlocks: introduce prop to specify render callback for each block. #24232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZebulanStanphill merged 13 commits into from
Aug 15, 2020
Merged

InnerBlocks: introduce prop to specify render callback for each block. #24232

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b193d5a
InnerBlocks: introduce prop to specify wrapper element for children.
ZebulanStanphill Jul 28, 2020
a875bd9
Initial save implementation.
ZebulanStanphill Jul 28, 2020
74ece38
For testing purposes: wrap each child of Group in section tag.
ZebulanStanphill Jul 28, 2020
f3c38d7
Fix save implementation over-escaping.
ZebulanStanphill Jul 28, 2020
9ac8811
Move wrapper logic from BlockList to BlockListBlock.
ZebulanStanphill Jul 28, 2020
35034af
Fix drag-and-drop for inner blocks.
ZebulanStanphill Jul 28, 2020
869ebfd
Initial native implementation.
ZebulanStanphill Jul 28, 2020
49c2e50
Remove need for 'block-editor-block-list-block__wrapper'.
ZebulanStanphill Aug 5, 2020
b458cf8
Switch to callback-based API.
ZebulanStanphill Aug 5, 2020
1a8abb2
Rename __experimentalCallback to __experimentalRenderCallback.
ZebulanStanphill Aug 6, 2020
c2d9634
Apply render callback at a slightly higher level.
ZebulanStanphill Aug 6, 2020
930091e
Remove obsolete unit test.
ZebulanStanphill Aug 7, 2020
7342bc1
Revert temporary Group block changes.
ZebulanStanphill Aug 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove obsolete unit test. 
getNearestBlockIndex now assumes all elements passed to it are the root elements of blocks; we filter out the other elements before passing the array to the function.
  • Loading branch information
@ZebulanStanphill
ZebulanStanphill committed Aug 15, 2020
commit 930091e9d02914676b54b4436c95bb9f2af38b42
16 changes: 0 additions & 16 deletions packages/block-editor/src/components/use-block-drop-zone/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,22 +83,6 @@ describe( 'getNearestBlockIndex', () => {
expect( result ).toBeUndefined();
} );

it( 'returns `undefined` if the elements do not have the `wp-block` class', () => {
const nonBlockElements = [
{ classList: createMockClassList( 'some-other-class' ) },
];
const position = { x: 0, y: 0 };
const orientation = 'horizontal';

const result = getNearestBlockIndex(
nonBlockElements,
position,
orientation
);

expect( result ).toBeUndefined();
} );

describe( 'Vertical block lists', () => {
const orientation = 'vertical';

Expand Down