Fix block movers overlapping #24349
Merged
Fix block movers overlapping #24349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +14 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 4, 2020
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Beautiful. Ship it. I verified the overflow property does not crop any focus styles. Nice.
youknowriad
added
the
Backport to WP 6.9 Beta/RC
ellatrix
pushed a commit
that referenced
this pull request
Aug 4, 2020
ellatrix
added a commit
that referenced
this pull request
Aug 4, 2020
* Block: fix html mode for non light blocks (#24335) * Block: fix html mode for non light blocks * Flatten * Fix inspector controls * fix movers overlapping (#24349) Co-authored-by: Nik Tsekouras <[email protected]>
youknowriad
pushed a commit
that referenced
this pull request
Aug 5, 2020
youknowriad
removed
the
Backport to WP 6.9 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #23983
More often than not, when attempting to move a block up by clicking on the Up arrow it moves the other way.
This is caused by overlapping
move iconssvg and is fixed in this PR.Before:
After:
Checklist: