Refactor and move drag and drop geometry code #24715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Code Quality
talldan
force-pushed
the
refactor/drag-and-drop-geometry-code
branch
from
3c257a5 to
1ec1e0d
Compare
|
Size Change: +58 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
talldan
requested review from
draganescu,
kevin940726,
noisysocks and
tellthemachines
draganescu
approved these changes
Aug 22, 2020
Contributor
draganescu
left a comment
draganescu
left a comment
There was a problem hiding this comment.
This works as described! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drag and drop in List View (#23952) will re-use the geometry code that determines the correct place to drop a block to.
This PR extracts some of the code, refactors it to be more generic, and adds some tests.
I considered moving this code to another package (like
@wordpress/dom), but couldn't see one that seemed relevant enough, so I've kept it in theblock-editorpackage in theutilsfolder.How has this been tested?
Added unit tests. Plus there's pretty decent existing unit tests for the block drag and drop that this affects.
Manual testing:
Screenshots
Types of changes
Non-breaking refactor
Checklist: