[edit-widgets] Make global inserter usable by passing correct rootClientId to it#24908
Merged
[edit-widgets] Make global inserter usable by passing correct rootClientId to it#24908
Conversation
adamziel
added
[Feature] Widgets Screen
adamziel
changed the title
Contributor
|
It appears it's not positioned correctly. It should be flush to the left of the Editor/screen? Adjacent to the black admin menu. I also noticed the tabs are missing. Is that intentional?
|
|
Size Change: +80 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
adamziel
changed the title
youknowriad
approved these changes
Aug 31, 2020
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Makes sense. I think the design is a separate issue as this was never refactored to use the "Panel" instead of the regular dropdown inserter.
Contributor
Author
|
One more change here would be inserting the widget to the most recently selected widget area instead of the first one as it happens ATM. |
adamziel
force-pushed
the
update/fix-inserter-in-widgets-editor
branch
from
1e2b9bf to
7169f8b
Compare
Contributor
|
I see this has been merged. |
Contributor
Author
|
I don't think it was merged just yet @paaljoachim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Global inserter is always inactive because it's receiving an incorrect
rootClientId. That's related to the somewhat novel way in which blocks in the widgets editor are set up. This PR ensures the correct value is passed.Before
After
How has this been tested?
Screenshots
Types of changes
Non-breaking change
Checklist: