Add tags support in Query block #25005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Themes
|
Size Change: +2.82 kB (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
add/query-tags-support
branch
from
bd20f32 to
c63bba1
Compare
ntsekouras
requested review from
Soean,
TimothyBJacobs,
ajitbohra,
nerrad,
ntwb,
spacedmonkey,
talldan and
youknowriad
as code owners
ntsekouras
commented
Sep 4, 2020
draganescu
approved these changes
Sep 7, 2020
Contributor
draganescu
left a comment
draganescu
left a comment
There was a problem hiding this comment.
Tested and read the code, LGTM!
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add
tagssupport inQueryblock and is part of #24934 and FSE milestone 5.There still needs to be a decision about the final design of
Queryblock, but that also depends on how many things we will include eventually and where ( toolbar, inspector controls etc..).For now I've added the
tagscontrols in thetoolbarlike the previously existedcategories. To me though this could be a better fit for inspector controls (maybe a follow up PR?). IMO since it's easy to move the functionality between the toolbar and the inspector controls, this enhances the functionality ofQueryblock and could be merged even without the finalized design.Also note that for now if you select both
tagsandcategoriesit defaults toANDquery for those. Maybe we should considertax relationin the future to allow theORoption.Finally this PR fixes a previous bug which didn't allow the selection of multiple categories in
Queryblock. The multiple terms are withORrelationship. That means if we have two categories [a, b] and one tag [tagLabel], it would fetcha+tagLabel OR b+tagLabel.Fixes: #25047
Checklist: