Skip to content

WIP: List View drag and drop optimizations #25069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
talldan wants to merge 12 commits into from
Closed

WIP: List View drag and drop optimizations #25069

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3f82bb6
Use useCallback on block drop zone callbacks
talldan Sep 3, 2020
e3fa9dc
Perform equality comparison before updating drop target
talldan Sep 3, 2020
2304e9d
Remove usage of block navigation block slot
talldan Sep 3, 2020
f5ad074
Memoize clientIds to avoid draggable re-render
talldan Sep 3, 2020
c8c8cbc
Optimise callbacks
talldan Sep 3, 2020
06f8bc5
Refactor useOnBlockDrop to avoid callback reference changing
talldan Sep 4, 2020
69d5177
Memoize classname changes for drag and drop
talldan Sep 4, 2020
69532d4
Use a separate provider to avoid unnecessary re-renders
talldan Sep 4, 2020
10b5916
Avoid rendering movers and settings menu when dragging
talldan Sep 4, 2020
a1688a3
Remove block navigation slot/fill for editing item text
talldan Sep 8, 2020
ab9b351
Fix issue with block settings menu not being displayed
talldan Sep 8, 2020
ec273dd
Fix move to option
talldan Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Memoize clientIds to avoid draggable re-render
  • Loading branch information
@talldan
talldan committed Sep 30, 2020
commit f5ad074d1177af05172f5587afb0f0c59774a6a2
8 changes: 5 additions & 3 deletions packages/block-editor/src/components/block-navigation/block-contents.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import classnames from 'classnames';
* WordPress dependencies
*/
import { useSelect } from '@wordpress/data';
import { forwardRef } from '@wordpress/element';
import { forwardRef, useMemo } from '@wordpress/element';

/**
* Internal dependencies
Expand Down Expand Up @@ -85,10 +85,12 @@ const BlockNavigationBlockContents = forwardRef(
}
);

const clientIds = useMemo( () => [ clientId ], [ clientId ] );

return (
<BlockDraggable
clientIds={ [ block.clientId ] }
elementId={ `block-navigation-block-${ block.clientId }` }
clientIds={ clientIds }
elementId={ `block-navigation-block-${ clientId }` }
>
{ ( { isDraggable, onDraggableStart, onDraggableEnd } ) => (
<BlockNavigationBlockSelectButton
Expand Down